RFR: 8266764: [REDO] JDK-8255493 Support for pre-generated java.lang.invoke classes in CDS dynamic archive [v6]

Yumin Qi minqi at openjdk.java.net
Fri May 14 17:53:38 UTC 2021


On Fri, 14 May 2021 17:31:27 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Yumin Qi has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>> 
>>  - Merge with master, resolve conflict
>>  - New added DynamicArchive::prepare_for_dynamic_dumping_at_exit should be CDS only
>>  - Fix whitespace
>>  - Added DynamicArchive::prepare_for_dynamic_dumping_at_exit to replace MetaspaceShared::regenerate_lambdaforminvokers_holders, the latter was removed. Added test case"
>>  - Remove unused variables
>>  - 8266764: [REDO] JDK-8255493 Support for pre-generated java.lang.invoke classes in CDS dynamic archive
>
> test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestDynamicDumpAtOom.java line 57:
> 
>> 55:              "1024").assertAbnormalExit(output -> {
>> 56:                  output.shouldContain("ArchiveClassesAtExit has failed")
>> 57:                         .shouldContain("java.lang.OutOfMemoryError: Java heap space");
> 
> One extra blank space before `.shouldContain` at line 57.

Thanks for catching the tiny difference!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3953


More information about the hotspot-runtime-dev mailing list