RFR: JDK-8266942: gtest/GTestWrapper.java os.iso8601_time_vm failed
Thomas Stuefe
stuefe at openjdk.java.net
Sat May 15 05:22:40 UTC 2021
On Fri, 14 May 2021 22:12:50 GMT, Xin Liu <xliu at openjdk.org> wrote:
>> My test only worked on half the globe, since the timezone stamp comparison was wrong (always compared for '+').
>>
>> Fixed that. Also made the UTC-variant-tests more strict by requiring the timezone delta to be 0000.
>>
>> Tested manually with various time zones.
>
> LGTM.
@navyxliu , @dcubed-ojdk Thanks for reviewing!
Strictly speaking this does not yet fulfill the requirements of 2 reviewers, since @navyxliu is no committer yet, but I declare this patch retroactively trivial (should have done this right away).
-------------
PR: https://git.openjdk.java.net/jdk/pull/4013
More information about the hotspot-runtime-dev
mailing list