RFR: 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report [v3]
Gerard Ziemski
gziemski at openjdk.java.net
Mon May 17 16:08:54 UTC 2021
On Mon, 17 May 2021 02:27:10 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> A simple fix to add a new VMErrorType (OOM_JAVA_HEAP_FATAL) to indicate we've requested a Java OOM error to be fatal. A new overload of report_fatal is provided to allow this to be passed through.
>>
>> VMError has an existing notion of "should_report_bug" but that encompasses more than just printing the bug submission URL, so I added a new specific check for that.
>>
>> Checked hs_err files before and after with the fix, from the CrashOnOutOfMemoryError test.
>>
>> Tested tiers 1-3 for good measure.
>>
>> Thanks,
>> David
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>
> Simplify API changes based on Gerard's suggestion.
Looks good, thanks!
-------------
Marked as reviewed by gziemski (Committer).
PR: https://git.openjdk.java.net/jdk/pull/4006
More information about the hotspot-runtime-dev
mailing list