RFR: 8266642: improve ResolvedMethodTable hash function [v8]

Denghui Dong ddong at openjdk.java.net
Tue May 18 02:24:41 UTC 2021


On Mon, 17 May 2021 11:22:49 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add missing include
>
> src/hotspot/share/classfile/classLoaderData.hpp line 331:
> 
>> 329: 
>> 330:   unsigned identity_hash() const {
>> 331:     return (unsigned)((uintptr_t)this >> (LogMinObjAlignmentInBytes + 3));
> 
> LogMinObjAlignmentInBytes describes the alignment requirements for Java objects. I know that some other places in the VM reuse this for generating hash codes, but I don't think that's appropriate, and they should be cleaned out.

Hi,
I think it makes sense.
How about filing a new JBS issue to fix the problem you mentioned or you think we should fix it in this patch?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3901


More information about the hotspot-runtime-dev mailing list