RFR: 8267155: runtime/os/TestTracePageSizes times out [v2]

Thomas Stuefe stuefe at openjdk.java.net
Tue May 18 04:07:23 UTC 2021


On Mon, 17 May 2021 16:39:59 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Cursory review follows.
> 
> The alternative would be to disable this on kernels < 3.8? See the commits from my last PR:
> https://github.com/openjdk/jdk/pull/3415/files/c7a6136cedb827260f43ecc850a8910492cfefcc..1df37de73ed6615db565aeafe76edf30dcee108d

Hmm, I like faster tests even on new kernels, therefore I would like to use this parser instead of the regex. Also think it makes the test more readable and robust, but that may be just me. E.g. you don't rely on order of entry in smaps. 

But we could do both, of course. Lets ask  @kstefanj , its his test.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4064


More information about the hotspot-runtime-dev mailing list