RFR: 8267155: runtime/os/TestTracePageSizes times out [v4]

Aleksey Shipilev shade at openjdk.java.net
Tue May 18 06:53:24 UTC 2021


On Tue, 18 May 2021 06:48:38 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> test/hotspot/jtreg/runtime/os/TestTracePageSizes.java line 161:
>> 
>>> 159:             debug = true;
>>> 160:         } else {
>>> 161:             debug = false;
>> 
>> Let's keep the code shape with explicit initialization here? Also drop the init at the field declaration?
>
> I did this to quickly turn on debug by changing the default value above. I could not figure out how to add command line parameters to the test on the jtreg command line and did not feel like modifying every single at-run. But I have no strong emotions, if you prefer I can reinstate the old behaviour.

Yeah, let's keep it the old way. You can change the `debug = true` right here next time, I think. IIRC, that's what I did before.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4064


More information about the hotspot-runtime-dev mailing list