RFR: 8267191: Avoid repeated SystemDictionaryShared::should_be_excluded calls [v2]

[Ioi Lam]

On Tue, 18 May 2021 06:42:53 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @dholmes-ora comments
>
> src/hotspot/share/classfile/systemDictionaryShared.cpp line 1409:
> 
>> 1407:   if (k->is_hidden() && !is_registered_lambda_proxy_class(k)) {
>> 1408:     ResourceMark rm;
>> 1409:     log_debug(cds)("Skipping %s: %s", k->name()->as_C_string(), "Hidden class");
> 
> You don't need to feed "Hidden class" to a %s.

Fixed.

> src/hotspot/share/classfile/systemDictionaryShared.cpp line 1416:
> 
>> 1414:   if (super != NULL && check_for_exclusion(super, NULL)) {
>> 1415:     ResourceMark rm;
>> 1416:     log_warning(cds)("Skipping %s: super class %s is excluded @%p", k->name()->as_C_string(), super->name()->as_C_string(), super);
> 
> Pretty sure we still don't/can't use %p in shared code, but should be INTPTR_FORMAT and use p2i(super)

I reverted back to the original code and removed the %p. I added %p for temporary debugging only.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4070