RFR: 8267191: Avoid repeated SystemDictionaryShared::should_be_excluded calls [v2]

[David Holmes]

On Tue, 18 May 2021 18:56:46 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> `SystemDictionaryShared::should_be_excluded` is called during CDS dump time to see if a class should be excluded from the archive. This function calls itself to check super types. As a result, some classes many be checked more than once.
>> 
>> The repeated calls slows down dumping. Also, If a class is excluded, we will see multiple warning messages like this, which is too verbose and confusing.
>> 
>> 
>> Skipping org/eclipse/osgi/util/NLS: Signed JAR
>> Skipping org/eclipse/osgi/util/NLS: Signed JAR
>> Skipping org/eclipse/osgi/util/NLS: Signed JAR
>> 
>> 
>> BTW, to make the code a little easier to read, I also changed
>> 
>> 
>>  warn_excluded(k, "Failed verification");
>>  return true;
>> 
>> 
>> to
>> 
>> 
>> return  warn_excluded(k, "Failed verification");
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @dholmes-ora comments

LGTM.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4070