RFR: 8267155: runtime/os/TestTracePageSizes times out [v5]
Thomas Stuefe
stuefe at openjdk.java.net
Thu May 20 05:18:32 UTC 2021
On Wed, 19 May 2021 19:12:27 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with four additional commits since the last revision:
>>
>> - fixes
>> - made kernel 3.8 mandatory
>> - Merge branch 'JDK-8267155-runtime-os-TestTracePageSize-times-out' of github.com:tstuefe/jdk into JDK-8267155-runtime-os-TestTracePageSize-times-out
>> - wip
>
> test/hotspot/jtreg/runtime/os/TestTracePageSizes.java line 44:
>
>> 42: * @requires vm.gc != "Z"
>> 43: * @run main/othervm -XX:+AlwaysPreTouch -Xmx128m -Xlog:pagesize:ps-%p.log -XX:+UseLargePages -XX:LargePageSizeInBytes=2m TestTracePageSizes
>> 44: * @run main/othervm -XX:+AlwaysPreTouch -Xmx128m -Xlog:pagesize:ps-%p.log -XX:+UseLargePages -XX:LargePageSizeInBytes=1g TestTracePageSizes
>
> Just realized that this test should probably not set `-Xmx128m` since we try to use 1g pages. What will happen is that the heap will be rounded up to 1G (the alignment logic here is a bit strange) so we will still test it, but it feels a bit backwards. Maybe set the heap to 1g in this case?
Good point.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4064
More information about the hotspot-runtime-dev
mailing list