RFR: 8265753: Remove manual JavaThread transitions to blocked [v6]

Robbin Ehn rehn at openjdk.java.net
Tue May 25 06:43:12 UTC 2021


On Mon, 24 May 2021 17:44:33 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Final fixes: last famous words
>
> src/hotspot/share/runtime/interfaceSupport.inline.hpp line 212:
> 
>> 210:     _thread->frame_anchor()->make_walkable(_thread);
>> 211:     OrderAccess::storestore();
>> 212:     _thread->set_thread_state(_thread_in_native);
> 
> Please add a comment to the `storestore()` call:
> // Keep thread_state change and make_walkable() separate.

Fixed

> src/hotspot/share/runtime/interfaceSupport.inline.hpp line 251:
> 
>> 249:     thread->frame_anchor()->make_walkable(thread);
>> 250:     OrderAccess::storestore();
>> 251:     thread->set_thread_state(_thread_blocked);
> 
> Please add a comment to the storestore() call:
> // Keep thread_state change and make_walkable() separate.

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/3875


More information about the hotspot-runtime-dev mailing list