RFR: 8267754: cds/appcds/loaderConstraints/LoaderConstraintsTest.java fails on x86_32 due to customized class loader is not supported [v2]

[David Holmes]

On Wed, 26 May 2021 04:08:35 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Hi all,
>> 
>> cds/appcds/loaderConstraints/LoaderConstraintsTest.java fails on x86_32.
>> This reason is that customized class loader is not supported on 32-bit systems [1].
>> It would be better to fix it.
>> 
>> Thanks.
>> Best regards,
>> Jie
>> 
>> 
>> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/cds/classListParser.cpp#L440
>
> Jie Fu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use Platform.areCustomLoadersSupportedForCDS

Hi Jie,

Fix looks good. But there is a pre-existing nit: shouldn't there be an else that throws SkippedException so that we can see the test was skipped and not vacuously  passed?

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4198