RFR: 8267754: cds/appcds/loaderConstraints/LoaderConstraintsTest.java fails on x86_32 due to customized class loader is not supported [v2]

[David Holmes]

On 26/05/2021 4:22 pm, Jie Fu wrote:
> On Wed, 26 May 2021 04:41:03 GMT, David Holmes <dholmes at openjdk.org> wrote:
> 
>>> Jie Fu has updated the pull request incrementally with one additional commit since the last revision:
>>>
>>>    Use Platform.areCustomLoadersSupportedForCDS
>>
>> Hi Jie,
>>
>> Fix looks good. But there is a pre-existing nit: shouldn't there be an else that throws SkippedException so that we can see the test was skipped and not vacuously  passed?
>>
>> Thanks,
>> David
> 
> Thanks @dholmes-ora for your review.
> 
>> Hi Jie,
>>
>> Fix looks good. But there is a pre-existing nit: shouldn't there be an else that throws SkippedException so that we can see the test was skipped and not vacuously passed?
>>
> 
> Got it.
> 
> We didn't throw SkippedException for this test since it would run doTest [1] even on 32-bit systems.

Got it. Sorry I misread the main method.

Thanks,
David

> Thanks.
> 
> [1] https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/runtime/cds/appcds/loaderConstraints/LoaderConstraintsTest.java#L65
> 
> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/4198
>