RFR: 8252476: as_Worker_thread() doesn't check what it intends [v3]

David Holmes dholmes at openjdk.java.net
Thu May 27 02:30:06 UTC 2021


On Wed, 26 May 2021 20:31:20 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Convert `as_Worker_thread` to non-virtual, like other `as_*_thread` methods.
>
> Albert Mingkun Yang has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - inline
>  - tmp

The update seems fine to me. But you need to check with @iklam  whether including nonJavaThread.hpp in thread.inline.hpp negates the point of splitting out nonJavaThread.hpp in the first place.

Thanks,
David

-------------

PR: https://git.openjdk.java.net/jdk/pull/4167


More information about the hotspot-runtime-dev mailing list