RFR: 8267095: Miscellaneous cleanups in vm.runtime.defmeth tests [v2]

[Vladimir Ivanov]

On Wed, 26 May 2021 13:13:57 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Vladimir Ivanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8267095.defmeth
>>  - Remove ACC_STRICT-related code
>>  - Cleanup
>>  - Remove scenarios
>>  - FIXME removal
>>  - Fixes
>>  - TestBuilder as a parameter
>
> test/hotspot/jtreg/vmTestbase/vm/runtime/defmeth/StressTest.java line 163:
> 
>> 161:             majorVerValues[i] = MIN_MAJOR_VER + i;
>> 162:         }
>> 163: 
> 
> Does this mean that the stress tests will run for all class versions between JDK 1.5 and JDK 17 ?  If so, maybe change it to just run for JDK 1.5, 11, and 17 releases?

It means that the stress test will randomly pick test cases with class file versions between `MIN_MAJOR_VER` and `MAX_MAJOR_VER`. IMO it's a decent compromise between testing only  `MIN_MAJOR_VER` and `MAX_MAJOR_VER` (all other defmeth tests are configured that way) and always enumerating all the class file versions in every test (`MIN_MAJOR_VER ... MAX_MAJOR_VER`). So, I'd prefer to keep it as is.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4008