RFR: 8267666: Add option to jcmd GC.heap_dump to use existing file [v2]

Lin Zang lzang at openjdk.java.net
Fri May 28 11:53:08 UTC 2021


On Fri, 28 May 2021 10:49:32 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Please review a small change that adds an option to GC.heap_dump to use an existing file. 
>> 
>> The option is necessary if the target file is a predefined file-like object, like a named pipe. This opens up a lot of possibilities to process a heap dump without storing it to the file system first.
>> 
>> Reviews of the CSR linked to the bug would be appreciated as well.
>
> Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Extend HeapDumpTest

Hi Anton,

> Is the label really required? I don't see any integrated RFR with the label. I won't push this before CSR is approved anyway.

AFAIK, the `csr` label will be removed by the `bot` when it gets approved.  I usually add it in PR when CSR is required, and maybe it could help reviewer notice it and hence review the CSR. Also it could help guarantee the PR not to be pushed when CSR is not approved.  

BRs,
Lin

-------------

PR: https://git.openjdk.java.net/jdk/pull/4183


More information about the hotspot-runtime-dev mailing list