RFR: 8264800: cleanup Threads_lock comments in JVM/TI function headers

Daniel D.Daugherty dcubed at openjdk.java.net
Sat May 29 16:35:17 UTC 2021


On Sat, 29 May 2021 15:47:02 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> A trivial fix to cleanup Threads_lock comments in JVM/TI function headers.
>> 
>> Also remove errant text added by the jframeID XSL template code:
>> 
>> 
>> // java_thread - unchecked
>> // depth - pre-checked as non-negative
>> 
>> 
>> The first line about `jthread` is output in error.
>> Only the second line about `depth` should be included.
>> 
>> This fix is tested with a Mach5 Tier1 job set.
>
> Yes, looks trivial and fine.

@coleenp - Thanks for the fast review! Do you think I should wait for a
Serviceability team member review or just integrate? I _think_ they still
trust me to change comments... :-)

-------------

PR: https://git.openjdk.java.net/jdk/pull/4254


More information about the hotspot-runtime-dev mailing list