RFR: 8275950: Use only _thread_in_vm in ~ThreadBlockInVMPreprocess() [v2]
Patricio Chilano Mateo
pchilanomate at openjdk.java.net
Mon Nov 1 14:38:43 UTC 2021
On Mon, 1 Nov 2021 14:18:11 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
> Thumbs up! I have only a minor comment nit.
>
> If I didn't know any better, I would think you're trying to remove the whole concept of "transition" states. :-)
>
Yes, for these cases they add unnecessary additional changes of state. : )
> src/hotspot/share/runtime/interfaceSupport.inline.hpp line 232:
>
>> 230: assert(_thread->thread_state() == _thread_blocked, "coming from wrong thread state");
>> 231: // Change to transition state and ensure it is seen by the VM thread.
>> 232: _thread->set_thread_state_fence(_thread_in_vm);
>
> The comment on L231 is now wrong since you're no longer using
> a "transition" state. Perhaps, "Change to an unsafe state..."
Fixed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6120
More information about the hotspot-runtime-dev
mailing list