RFR: 8275775: VM.metaspace prints flag 'f' for classes that have non-trivial finalize() [v3]

[Yi Yang]

On Wed, 27 Oct 2021 01:30:37 GMT, Yi Yang <yyang at openjdk.org> wrote:

>> Some customers want to observe which loaded classes have overridden the finalize() method. I found that VM.metaspace can output detailed classes. It seems feasible to add 'f' flag to it. With this patch, I found that ZipFileSystem left a finalize after applying this patch, which was obsolete 5 years ago, maybe we should remove it?
>
> Yi Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   typo

> _Mailing list message from [David Holmes](mailto:david.holmes at oracle.com) on [hotspot-runtime-dev](mailto:hotspot-runtime-dev at mail.openjdk.java.net):_
> 
> On 2/11/2021 3:26 pm, Thomas Stuefe wrote:
> 
> > On Tue, 2 Nov 2021 00:14:48 GMT, David Holmes <dholmes at openjdk.org> wrote:
> > > > I like this (also the succinct name). Unfortunately, this would need a CSR, but if you have not yet done that we can help with this.
> > > 
> > > 
> > > @tstuefe We do not use CSR requests with jcmd changes as they are deemed diagnostic commands - ref JDK-8203682 :)
> > 
> > 
> > Seems odd since these are outside interfaces, used in scripts and whatnot. IMHO one of the places where CSR really makes sense.
> 
> From [1]
> 
> David > 1. Have we previously established whether a CSR request is needed for a new Dcmd?
> 
> Thomas > "My feeling is no, since this adds a new command, so there can be no backward compat issues."
> 
> :)
>
> [1] http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2018-May/028190.html
> 
> Everyone is entitled to change their mind of course, but new commands don't have compatibility issues as you point out. And diagnostic interfaces don't need to go through the CSR process. So ...
> 
> Cheers, David

So let me try to do that~ People can still leave their comments on PR. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6075