RFR: 8276184: Exclude lambda proxy class from the CDS archive if its caller class is excluded [v4]
Ioi Lam
iklam at openjdk.java.net
Mon Nov 8 21:13:38 UTC 2021
On Mon, 8 Nov 2021 05:06:16 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> The proposed patch has been redone completely to address the problem when a caller class is being excluded
>> from the archive, the associated lambda proxy class(es) was not excluded.
>>
>> The caller class could be excluded if:
>> - it is signed;
>> - it has been redefined after its lambda proxy class was created.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>
> @iklam comments
LGTM. Just a small suggestion for an additional message check.
test/hotspot/jtreg/runtime/cds/appcds/SignedJar.java line 70:
> 68: // Test class exists in both signed JAR and unsigned JAR
> 69: String jars = signedJar + System.getProperty("path.separator") + unsignedJar;
> 70: output = TestCommon.dump(jars, TestCommon.list(mainClass));
Does the VM log a message for the excluded lambda proxy as well? If so, maybe we should check that here, too.
-------------
Marked as reviewed by iklam (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/6205
More information about the hotspot-runtime-dev
mailing list