RFR: 8276825: hotspot/runtime/SelectionResolution test errors [v2]

Harold Seigel hseigel at openjdk.java.net
Tue Nov 9 20:16:35 UTC 2021


On Tue, 9 Nov 2021 20:12:05 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Please review this trivial fix to a few of the hotspot/runtime/SelectionResolution test class files.  The fix was tested by running the tests locally and Mach5 tiers 1-3 on Linux, MacOS, and Windows.
>> 
>> Thanks, Harold
>
> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change adding of access options to or-ing

Thanks David and Aleksey for the reviews.

The tests passed by accident.  The calls to the Clazz constructor happen to succeed because the constructor adds ACC_SUPER to the incoming access.  When the access is -1, this results in access being set to 31 because ACC_SUPER equals 32.

I changed the Clazz cosntructor java to 'or' the incoming access with ACC_SUPER instead of adding it.  This will prevent the test from succeeding in the future if an index of -1 is passsed as the access.

Does this latest change look okay?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6300


More information about the hotspot-runtime-dev mailing list