Integrated: 8276215: Intrinsics matchers should handle native method flags better

Aleksey Shipilev shade at openjdk.java.net
Wed Nov 10 10:49:43 UTC 2021


On Mon, 1 Nov 2021 12:22:37 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Found this while working on JDK-8276096. It seems when the actual method is native, `F_R` (regular) intrinsic definition still matches. I believe that happens because flag matchers check for native flags only optionally. It would be better to implement this more consistently. This requires a few simple adjustments to current intrinsics definitions. #6184 handled a larger `StrictMath` oddity.
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug `tier1`
>  - [x] Linux x86_64 fastdebug `tier2`
>  - [x] Linux x86_64 fastdebug `applications/ctw/modules` (which has a nice side-effect of touching a lot of JDK methods)

This pull request has now been integrated.

Changeset: a3f710ef
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/a3f710efbe7dcef18477a96fd306bec19f181f8b
Stats:     79 lines in 2 files changed: 50 ins; 0 del; 29 mod

8276215: Intrinsics matchers should handle native method flags better

Reviewed-by: dholmes, kvn

-------------

PR: https://git.openjdk.java.net/jdk/pull/6187


More information about the hotspot-runtime-dev mailing list