RFR: 8276184: Exclude lambda proxy class from the CDS archive if its caller class is excluded [v6]

Ioi Lam iklam at openjdk.java.net
Tue Nov 16 02:41:44 UTC 2021


On Tue, 16 Nov 2021 02:11:31 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Hi Calvin,
> 
> This versions seems much better - thanks.
> 
> I still really dislike `SystemDictionaryShared::warn_excluded` always returning true but that's not an issue for this PR. :)
> 
> Thanks, David

It's a matter of style. The current syntax is more concise, and avoids coding errors like these:


    if (...) {
       warn_excluded("some message");
       // forgets to return
    }
    if (...) {
       warn_excluded("some message");
       return false; // returns the wrong value
    }

-------------

PR: https://git.openjdk.java.net/jdk/pull/6205


More information about the hotspot-runtime-dev mailing list