RFR: 8276787: Improve warning messages for -XX:+RecordDynamicDumpInfo [v2]

[Thomas Stuefe]

On Tue, 16 Nov 2021 06:30:02 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> [1] Fixed the error messages for the three scenarios described in the bug report. See the test SharedArchiveFileOption.java for new test cases for these messages.
>> 
>> [2] The global SharedDynamicArchivePath was used for both reading and writing the dynamic archive. Now the writing part is handled by DynamicArchiveBuilder::_archive_name. This simplifies the logic in Arguments::init_shared_archive_paths() and DynamicArchive::dump_for_jcmd(). It also makes the checks in [1] easier to implement.
>> 
>> Testing: running through Oracle CI tiers 1-4.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @calvinccheung comments

Hi Ioi,

I am not an AppCDS expert, but to me, this looks good.

Thanks, Thomas

src/hotspot/share/cds/dynamicArchive.cpp line 339:

> 337: 
> 338: class VM_PopulateDynamicDumpSharedSpace: public VM_GC_Sync_Operation {
> 339:   DynamicArchiveBuilder builder;

nit, preexisting, but should members not be prefixed with _?

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6383