RFR: 8276787: Improve warning messages for -XX:+RecordDynamicDumpInfo [v3]

Ioi Lam iklam at openjdk.java.net
Tue Nov 16 18:53:08 UTC 2021


> [1] Fixed the error messages for the three scenarios described in the bug report. See the test SharedArchiveFileOption.java for new test cases for these messages.
> 
> [2] The global SharedDynamicArchivePath was used for both reading and writing the dynamic archive. Now the writing part is handled by DynamicArchiveBuilder::_archive_name. This simplifies the logic in Arguments::init_shared_archive_paths() and DynamicArchive::dump_for_jcmd(). It also makes the checks in [1] easier to implement.
> 
> Testing: running through Oracle CI tiers 1-4.

Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch 'master' into 8276787-improve-RecordDynamicDumpInfo-messages
 - @tstuefe review - small coding style fix
 - @calvinccheung comments
 - fixed trailing whitespaces
 - 8276787: Improve warning messages for -XX:+RecordDynamicDumpInfo

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/6383/files
  - new: https://git.openjdk.java.net/jdk/pull/6383/files/346c1d9e..5a4de263

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6383&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6383&range=01-02

  Stats: 24837 lines in 229 files changed: 18281 ins; 2466 del; 4090 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6383.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6383/head:pull/6383

PR: https://git.openjdk.java.net/jdk/pull/6383


More information about the hotspot-runtime-dev mailing list