RFR: 8277531: Print actual default stacksize on Windows thread logging

David Holmes dholmes at openjdk.java.net
Mon Nov 22 13:18:05 UTC 2021


On Mon, 22 Nov 2021 09:22:39 GMT, Takuya Kiriyama <duke at openjdk.java.net> wrote:

> I modified to log actual stack size on Windows by using `os::win32::default_stack_size()`.
> Could you please review this fix?

This change seems reasonable, but it appears to me that default_stack_size() actually reports the stack size of the initial thread, which AFAIK could be modified by passing -Xss, so it would not be the default afterall.

David

test/hotspot/jtreg/runtime/logging/TestLogThreadStackSize.java line 30:

> 28:  * @summary os+thread output should contain actual thread size for thread start
> 29:  * @library /test/lib
> 30:  */

Test should use:

`@run driver TestLogThreadStackSize`

-------------

PR: https://git.openjdk.java.net/jdk/pull/6495


More information about the hotspot-runtime-dev mailing list