RFR: 8273342: Null pointer dereference in classFileParser.cpp:2817

David Holmes dholmes at openjdk.java.net
Mon Oct 4 23:01:06 UTC 2021


On Mon, 4 Oct 2021 17:34:02 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

> Hi,
> 
> Please review this fix to always return a non-null value from fieldDescriptor::generic_signature() when a generic signature exists, even in places in the function that should never get executed.  This will prevent code analyzers from complaining about possible null dereferences by callers of generic_signature().
> 
> The change was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.
> 
> Thanks, Harold

LGTM!

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5807


More information about the hotspot-runtime-dev mailing list