RFR: 8274282: Clarify special wait assert [v4]

Coleen Phillimore coleenp at openjdk.java.net
Tue Oct 5 15:03:42 UTC 2021


On Tue, 5 Oct 2021 14:56:54 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update comment, maybe clearer?
>
> src/hotspot/share/runtime/mutex.cpp line 390:
> 
>> 388:     // because the held lock has a NoSafepointVerifier so waiting on a lower ranked lock will not be
>> 389:     // able to check for safepoints first with a TBIVM.
>> 390:     // For all threads, we enforce not waiting on the tty lock since that could block progress also.
> 
> I think this should be s/on the tty lock/while holding the tty lock or below.

fixed, thanks for the suggestion. It's more correct.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5684


More information about the hotspot-runtime-dev mailing list