RFR: JDK-8273914: Indy string concat changes order of operations [v2]

Liam Miller-Cushon cushon at openjdk.java.net
Thu Oct 7 19:47:48 UTC 2021


On Thu, 7 Oct 2021 10:00:36 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Liam Miller-Cushon has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Also test evaluation order for 'inline'
>>  - Remove sharpestAccessible logic, since types are now passed as strings
>
> test/langtools/tools/javac/StringConcat/StringAppendEvaluatesInOrder.java line 28:
> 
>> 26:  * @bug     8273914
>> 27:  * @summary Indy string concat changes order of operations
>> 28:  *
> 
> Here and later: please add the test block with `-XDstringConcat=inline` here as well, so that test would verify that every javac strategy produces the same result?

Done, thanks

-------------

PR: https://git.openjdk.java.net/jdk/pull/5844


More information about the hotspot-runtime-dev mailing list