RFR: JDK-8273914: Indy string concat changes order of operations [v5]

Aleksey Shipilev shade at openjdk.java.net
Fri Oct 15 08:37:47 UTC 2021

On Thu, 14 Oct 2021 17:10:20 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> Ah, I missed that `WellKnownTypes` does not verify concat output. Yes, that resolves my concern, we don't need to handle `inline` there. Maybe rename `WellKnownTypes` to `WellKnownTypeSignatures` or something?
>> But yes, I think adding another test that verifies the "special" input types produce consistent results across all strategies would be useful.
> Sure, thanks--I renamed `WellKnownTypes` to `WellKnownTypeSignatures`, and added a new ` WellKnownTypes` that tests the actual concat behaviour on primitives for all of the strategies.

Thank you, the last change resolves my comments.


PR: https://git.openjdk.java.net/jdk/pull/5844

More information about the hotspot-runtime-dev mailing list