RFR: 8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info [v2]

Calvin Cheung ccheung at openjdk.java.net
Fri Oct 22 18:41:46 UTC 2021


On Fri, 22 Oct 2021 16:57:19 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove empty CleanupDumpTimeLambdaProxyClassTable ctor
>
> src/hotspot/share/classfile/systemDictionaryShared.cpp line 1603:
> 
>> 1601: class CleanupDumpTimeLambdaProxyClassTable: StackObj {
>> 1602:  public:
>> 1603:   CleanupDumpTimeLambdaProxyClassTable() {}
> 
> Why need a explicit public constructor for nothing?

Thanks for your review.
In a previous version of the fix, the `_dumptime_lambda_proxy_class_dictionary` was passed to the constructor but it is no longer needed. I've removed the constructor.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6070


More information about the hotspot-runtime-dev mailing list