RFR: 8261455: Automatically generate the CDS archive if necessary [v3]

[Yumin Qi]

On Fri, 22 Oct 2021 22:34:00 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make FileHeaderHelper::read_base_archive_name return char*, also cleaned up some check code
>
> src/hotspot/share/runtime/java.cpp line 60:
> 
>> 58: #include "oops/symbol.hpp"
>> 59: #include "prims/jvmtiExport.hpp"
>> 60: #include "runtime/arguments.hpp"
> 
> Is this `#include` needed?

This is leftover from last change, it should be removed. Thanks.

> test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchive.java line 255:
> 
>> 253: 
>> 254:          // 20 Testing with -XX:SharedArchiveFile=top:base
>> 255:          print("20 Testing with -XX:SharedArchiveFile=top:base");
> 
> Do you mean `-XX:SharedArchiveFile=base:top`?

Yes, the order should be reversed.

> test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchive.java line 273:
> 
>> 271:                        .shouldContain("Dumping shared data to file:")
>> 272:                        .shouldContain(TOP_NAME);
>> 273:              });
> 
> Suggestion: add `checkFileExists(TOP_NAME)`.

I will add check file existence or non-existence.
Thanks for review!

-------------

PR: https://git.openjdk.java.net/jdk/pull/5997