RFR: 8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info [v2]

[David Holmes]

On Mon, 25 Oct 2021 04:21:02 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> src/hotspot/share/cds/metaspaceShared.cpp line 515:
>> 
>>> 513:   HeapShared::run_full_gc_in_vm_thread();
>>> 514: 
>>> 515:   SystemDictionaryShared::start_dumping();
>> 
>> What is the significance of this? It seems unrelated to the bug being fixed.
>
> It is for setting the `_dump_in_progress` flag to true so that no new entries will be added to the `_dumptime_table`.
> The `SystemDictionaryShared::start_dumping()` is being called for the dynamic dumping case, it would be consistent
> if it is also called for the static dumping case.

Perhaps but again that seems a different issue unrelated to this bug. Nor is it immediately obvious that the dynamic dumping and static dumping are equivalent in this regard. If the flag was only added for the dynamic case then apparently the static case does not need it - no?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6070