RFR: 8275950: Use only _thread_in_vm in ~ThreadBlockInVMPreprocess() [v2]
Patricio Chilano Mateo
pchilanomate at openjdk.java.net
Wed Oct 27 14:39:10 UTC 2021
On Wed, 27 Oct 2021 02:16:10 GMT, David Holmes <dholmes at openjdk.org> wrote:
> Hi Patricio,
>
> This change seems fine.
>
> I note that there are only two callers to `is_a_block_safe_state`:
>
> * ` SafepointSynchronize::block`
> * `SafepointMechanism::process`
>
> but ` SafepointSynchronize::block` is itself now only called from `SafepointMechanism::process`, so we don't the assert of `is_a_block_safe_state` in ` SafepointSynchronize::block`.
>
Right. I removed the extra assert.
Thanks for the review David!
Patricio
-------------
PR: https://git.openjdk.java.net/jdk/pull/6120
More information about the hotspot-runtime-dev
mailing list