RFR: JDK-8276039: Incomplete resolution operator for set_init_lock in javaClasses.cpp

Yumin Qi minqi at openjdk.java.net
Wed Oct 27 15:12:09 UTC 2021


On Wed, 27 Oct 2021 05:29:12 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Delete the "label"

There are other similarity for static members like this in the same file: 
1007:    java_lang_Class::set_klass(mirror(), k);
1012:    java_lang_Class::set_static_oop_field_count(mirror(), mk->compute_static_oop_field_count(mirror()));
1041:        java_lang_Class::set_klass(mirror(), NULL);
1131:  assert(java_lang_Class::is_instance(mirror_obj), "must be");
1245:      oop comp_mirror = java_lang_Class::component_mirror(mirror);
1257:    java_lang_Class::set_component_mirror(archived_mirror, archived_comp_mirror);
1264:    java_lang_Class::set_init_lock(archived_mirror, NULL);
1377:  java_lang_Class::set_module(k->java_mirror(), module());
1465:    o = StringTable::intern(java_lang_Class::as_external_name(java_class()), THREAD);
1492:  assert(java_lang_Class::static_oop_field_count(java_class) == 0, "should have been zeroed by allocation");
1498:  assert(java_lang_Class::is_instance(java_class), "must be a Class object");
1504:  assert(java_lang_Class::is_instance(java_class), "must be a Class object");
1524:  assert(java_lang_Class::is_instance(java_class), "must be a Class object");
1555:  assert(java_lang_Class::is_instance(java_class), "must be a Class object");
1582:  assert(java_lang_Class::is_primitive(java_class), "just checking");
1596:  assert(java_lang_Class::is_instance(java_class), "must be a Class object");
1612:  assert(java_lang_Class::is_primitive(mirror), "must be primitive");
2263:  InstanceKlass* holder = InstanceKlass::cast(java_lang_Class::as_Klass(mirror()));
2633:    InstanceKlass* holder = InstanceKlass::cast(java_lang_Class::as_Klass(bte._mirror()));
2706:  InstanceKlass* holder = InstanceKlass::cast(java_lang_Class::as_Klass(bte._mirror()));
2745:  oop classname = java_lang_Class::name(java_class, CHECK);
2799:  source_file = java_lang_Class::source_file(java_class());
2805:      java_lang_Class::set_source_file(java_class(), source_file);
2811:      java_lang_Class::set_source_file(java_class(), source_file);
2885:  Klass* clazz = java_lang_Class::as_Klass(java_lang_invoke_MemberName::clazz(mname()));
3485:  Klass* k = java_lang_Class::as_Klass(mirror);
4090:    java_lang_Class::print_signature(pts->obj_at(i), st);
4093:  java_lang_Class::print_signature(rtype(mt), st);
4148:    BasicType bt = java_lang_Class::as_BasicType(pts->obj_at(i));
4155:  BasicType bt = java_lang_Class::as_BasicType(rtype(mt));

I would like to keep this as others --- maybe the original author like it used this way.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6130


More information about the hotspot-runtime-dev mailing list