RFR: 8274980: Improve adhoc build version strings [v2]
erikj at openjdk.java.net
Thu Oct 28 13:16:10 UTC 2021
On Thu, 28 Oct 2021 12:58:35 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Current adhoc version build strings are not ideal. Some of the problems:
>> * A build number of "0" is inserted, which make the version string look like it's an official build, at least when not reading carefully
>> * The version string gives little indication on what source code the build was based
>> Also, an error was discovered in how the build system generates version strings without a build number (since this basically never happened before). A version without a build number, and without a PRE value, but with an OPT value, should have a "+-" separator, according to JEP 223. While this was correctly handled, the "+-" separator was also applied to versions without a build, but with both PRE and OPT. In this case, the "+" should be omitted, according to JEP 223. This bug is fixed by this commit.
>> Ideally, the adhoc version string should include something along the lines of the output of `git describe`. However, since the version string is set at configure time, not build time, this will almost immediately become misleading. :-( A substitute is proposed in this patch, where the branch name is included in the OPT string (if it's not `master`).
>> Finally, this patch fixes hotspot so it can properly build without a build number. This was the last blocker for why the build system always required the "0" as build number before. To facilitate interoperability with external tools (like jib) that still sets build number to "0" to really signal "no build number", a build number exactly matching "0" will be interpreted as having no build number.
> Magnus Ihse Bursie has updated the pull request incrementally with three additional commits since the last revision:
> - Break long lines
> - Skip setting git branch in adhoc version opt
> - Fix for abtract_vm_version so it really handles empty VERSION_BUILD
The setting of build_number to 0 is done from jib-profiles.js so we can definitely change that if we want to differentiate between 0 and empty.
More information about the hotspot-runtime-dev