RFR: JDK-8275440: Remove VirtualSpaceList::is_full()

Coleen Phillimore coleenp at openjdk.java.net
Thu Oct 28 15:32:13 UTC 2021


On Thu, 28 Oct 2021 06:18:39 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> This function is only used from a single gtest. Ioi remarked that it is not threadsafe. The context in which it is used is not multithreaded, but nevertheless I opted to remove the function and modified the test to make the condition somewhat more generic.
> 
> This trades a slight decrease in complexity with a very minor decrease in test precision, but that is fine.
> 
> Test: 
> - manual gtests
> - GHAs
> - ran the metaspace jtreg gtests, which execute gtests with various metaspace modes

Looks good, also looks trivial.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6147


More information about the hotspot-runtime-dev mailing list