RFR: JDK-8275608: runtime/Metaspace/elastic/TestMetaspaceAllocationMT2 too slow [v2]

Aleksey Shipilev shade at openjdk.java.net
Fri Oct 29 09:06:10 UTC 2021


On Fri, 29 Oct 2021 08:51:19 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   adapt copyrights
>
> test/hotspot/jtreg/runtime/Metaspace/elastic/RandomAllocator.java line 78:
> 
>> 76:     // Randomly choose one of the allocated in the deallocation list and deallocate it
>> 77:     void deallocateRandomly() {
>> 78:         breatheTicks ++;
> 
> Suggestion:
> 
>         breatheTicks++;

This also increments `breatheTicks` when we are allocating and enter this path while deallocating randomly? Probably fine, as long as that is intentional.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6041


More information about the hotspot-runtime-dev mailing list