RFR: JDK-8276039: Remove unnecessary qualifications of java_lang_Class:: [v2]
David Holmes
david.holmes at oracle.com
Fri Oct 29 21:51:09 UTC 2021
On 30/10/2021 7:44 am, Yumin Qi wrote:
> On Wed, 27 Oct 2021 23:00:42 GMT, Yumin Qi <minqi at openjdk.org> wrote:
>
>>> Please review,
>>>
>>> I have no idea why this problem has not been encountered in compilation, it is obvious the usage of resolution operator :: is not complete and wrong.
>>>
>>> Tests: mach5 tier1, tier4
>>>
>>> Thanks
>>> Yumin
>>
>> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove unnecessary qualifier scope operator in class java_lang_Class
>
> Hi, David
> Are you off today? I think the change is simple and also waited for one day --- no objection so do the push.
I was off yesterday (today is Saturday :) )
The change is simple, but the point is you should have at least had your
initial reviewers re-review the second version.
Cheers,
David
> Thanks for your input.
>
> -------------
>
> PR: https://git.openjdk.java.net/jdk/pull/6130
>
More information about the hotspot-runtime-dev
mailing list