RFR: 8273251: Call check_possible_safepoint() from SafepointMechanism::process_if_requested()

David Holmes dholmes at openjdk.java.net
Thu Sep 2 08:02:36 UTC 2021


On Wed, 1 Sep 2021 20:53:46 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

> Hi,
> 
> Please review this small fix to call check_possible_safepoint() from SafepointMechanism::process_if_requested() and remove the same call from transition_and_process(). See the bug description for more detail.
> Since there were only two lines left of common code from transition_from_native() and transition_from_vm() I just removed transition_and_process() altogether. This also saves an unneeded extra transition to _thread_in_vm when transitioning from vm to Java.
> 
> Testing tiers 1-6.
> 
> Thanks,
> Patricio

Looks good! Thanks for the cleanup Patricio: fewer functions and no redundant state changes.

Cheers,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5342


More information about the hotspot-runtime-dev mailing list