RFR: 8273112: -Xloggc and -Xlog should override -verbose [v3]

Xiaowei Lu github.com+39413832+weixlu at openjdk.java.net
Fri Sep 3 02:31:29 UTC 2021


On Fri, 3 Sep 2021 02:03:29 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Xiaowei Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove code in previous commit
>
> src/hotspot/share/runtime/arguments.cpp line 95:
> 
>> 93: char*  Arguments::SharedDynamicArchivePath      = NULL;
>> 94: 
>> 95: LegacyGCLogging Arguments::_legacyGCLogging     = { 0 };
> 
> `{ 0, 0}` ? Or is it implied the other members are zero-initialized?

@dholmes-ora I think compiler will assign 0 to all members of this struct. Since you have mentioned this here, let's explicitly use { 0, 0} to avoid potential problems.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5295


More information about the hotspot-runtime-dev mailing list