RFR: 8272164: DumpAllocStats shouldn't subclass from ResourceObj [v3]

David Holmes dholmes at openjdk.java.net
Sat Sep 4 04:57:46 UTC 2021


On Sat, 4 Sep 2021 03:30:19 GMT, Dan Heidinga <github.com+8503711+DanHeidinga at openjdk.org> wrote:

>> I picked up a simple unassigned bug to work through the contribution process.
>> 
>> `make run-test-tier1` passes with this change.
>> 
>> Signed-off-by: Dan Heidinga <heidinga at redhat.com>
>
> Dan Heidinga has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Explicitly mark as StackObj subclass

Hi Dan,

This version also seems fine. I'm not sure where we stand with using `StackObj` these days in terms of style (ie is it just a historical anachronism?). But in this case `DumpAllocStats` only has a single use embedded within `ArchiveBuilder` which is itself a `StackObj` - so this seems fine either way.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5362


More information about the hotspot-runtime-dev mailing list