RFR: 8273333: Zero should warn about unimplemented -XX:+LogTouchedMethods

David Holmes dholmes at openjdk.java.net
Sun Sep 5 23:46:54 UTC 2021


On Fri, 3 Sep 2021 15:29:36 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Currently Zero VM does not implement -XX:+LogTouchedMethods runtime features, which makes `runtime/CommandLine/PrintTouchedMethods.java` tier1 test fail with it.
> 
> Instead of implementing it (risking performance and rare bugs), Zero should just reject the option. 
> 
> Additional testing:
>  - [x] Eyeballing failure message
>  - [x] Affected test does not run with Zero anymore
>  - [x] Affected test still runs with Server

Looks fine.

One style nit.

Thanks,
David

test/hotspot/jtreg/runtime/CommandLine/PrintTouchedMethods.java line 27:

> 25:  * @test
> 26:  * @requires vm.flavor != "zero"
> 27:  * @bug 8025692 8273333

Nit: these lines tend to be in the other order

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5363


More information about the hotspot-runtime-dev mailing list