RFR: 8273104: Refactoring option parser for UL [v2]

[Yasumasa Suenaga]

On Tue, 7 Sep 2021 00:15:25 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix condition for error stream
>
> src/hotspot/share/logging/logOutput.cpp line 370:
> 
>> 368:     if (!success) {
>> 369:       if (errstream->count() > errstream_count_before) {
>> 370:         errstream->print_cr("Invalid option '%s' for log output (%s).", key, name());
> 
> I don't quite follow this. If the error count has increased then this was a known option with a bad value that has already been reported in set_option. Here we should be catching an unknown option that wasn't recognized by set_option, in which case the error count should be unchanged no?

Good catch! I fixed it in new commit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5293