Integrated: 8231356: Fix broken ResourceObj::operator new[] in debug builds

[Leo Korinth]

On Mon, 9 Aug 2021 14:31:22 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

> ResourceObj::operator new[] calls ResourceObj::operator new (non array version). In debug builds, each resource object (on C_HEAP) will be initialized with set_allocation_type() (which is correct). What is not correct is that the constructor (and thus) set_allocation_type() is called on the array itself (which is not a ResourceObj). This initialization will be partially overwritten by the header that keeps track of the array size. When the array destructor later is called, it will also chain call the non-array destructor. In debug builds the verification of _allocation_t[0] will fail as it has been overwritten by the code that keeps track of the array size.
> 
> The following assert will fail:
> assert(~(_allocation_t[0] | allocation_mask) == (uintptr_t)this, "lost resource object");
> 
> The reason that it has not been detected is that no one uses ResourceObj::operator new[] on resource objects with C_HEAP storage.

This pull request has now been integrated.

Changeset: 3cd95a29
Author:    Leo Korinth <lkorinth at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/3cd95a2932ab6a2cb39322354f7ad181de8bfc9e
Stats:     37 lines in 2 files changed: 0 ins; 31 del; 6 mod

8231356: Fix broken ResourceObj::operator new[] in debug builds

Reviewed-by: kbarrett, iklam

-------------

PR: https://git.openjdk.java.net/jdk/pull/5055