RFR: 8273433: Enable parallelism in vmTestbase_nsk_sysdict tests
David Holmes
david.holmes at oracle.com
Tue Sep 7 13:31:14 UTC 2021
Hi Aleksey,
On 7/09/2021 11:24 pm, Aleksey Shipilev wrote:
> Current `vmTestbase_nsk_sysdict` suite contains about 20 tests, each running exclusively. There seem to be no reason to run them exclusively, though: they complete in reasonable time, are single-threaded, and consume the usual amount of memory.
I (or someone) will to need to check the history here. There's always a
reason tests were set to run exclusively.
Thanks,
David
> We should consider enabling parallelism for them and get improved test performance. Currently it is blocked by `TEST.properties` with `exclusiveAccess.dirs` directives in them.
>
> Motivational performance improvements below.
>
> Before:
>
>
> $ time CONF=linux-x86_64-server-fastdebug make run-test TEST=vmTestbase_nsk_sysdict | ts -s
> ...
> 00:45:14 ==============================
> 00:45:14 Test summary
> 00:45:14 ==============================
> 00:45:14 TEST TOTAL PASS FAIL ERROR
> 00:45:14 jtreg:test/hotspot/jtreg:vmTestbase_nsk_sysdict 20 20 0 0
> 00:45:14 ==============================
> 00:45:14 TEST SUCCESS
> 00:45:14
> 00:45:15 Finished building target 'run-test' in configuration 'linux-x86_64-server-fastdebug'
>
> real 45m14.839s
> user 149m49.850s
> sys 13m25.849s
>
>
> After:
>
>
> $ time CONF=linux-x86_64-server-fastdebug make run-test TEST=vmTestbase_nsk_sysdict | ts -s
> ...
> 00:03:25 ==============================
> 00:03:25 Test summary
> 00:03:25 ==============================
> 00:03:25 TEST TOTAL PASS FAIL ERROR
> 00:03:25 jtreg:test/hotspot/jtreg:vmTestbase_nsk_sysdict 20 20 0 0
> 00:03:25 ==============================
> 00:03:25 TEST SUCCESS
> 00:03:25
> 00:03:25 Finished building target 'run-test' in configuration 'linux-x86_64-server-fastdebug'
>
> real 3m24.702s
> user 119m7.488s
> sys 8m11.716s
>
> -------------
>
> Commit messages:
> - Remove TEST.properties
>
> Changes: https://git.openjdk.java.net/jdk/pull/5389/files
> Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5389&range=00
> Issue: https://bugs.openjdk.java.net/browse/JDK-8273433
> Stats: 20 lines in 20 files changed: 0 ins; 20 del; 0 mod
> Patch: https://git.openjdk.java.net/jdk/pull/5389.diff
> Fetch: git fetch https://git.openjdk.java.net/jdk pull/5389/head:pull/5389
>
> PR: https://git.openjdk.java.net/jdk/pull/5389
>
More information about the hotspot-runtime-dev
mailing list