RFR: 8271569: Change cdsoffsets.cpp to cdsConstants.cpp
Yumin Qi
minqi at openjdk.java.net
Thu Sep 9 04:28:01 UTC 2021
On Wed, 8 Sep 2021 22:44:14 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Changed cdsOffsets.cpp to cdsConstants.cpp, now the offsets and constants are initialized static and searched separately.
>> The offsets array could not use 'constexpr' since g++ on MacOs and VSC++ on Windows complained reinterpret_cast in 'offset_of' should not be used in constexpr initialization. Changed some field access for forming global list first.
>>
>> Tests: ter1-4
>>
>> Thanks
>> Yumin
>
> Hi Yumin,
>
>> Changed cdsOffsets.cpp to cdsConstants.cpp
>
> This is not showing up in the PR as a rename but as a new file. So there is no way to know what changes you may have made inside cdsConstants.cpp. The header file change shows as a rename.
>
> David
@dholmes-ora I see your point here --- let me redo the patch using rename.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5423
More information about the hotspot-runtime-dev
mailing list