RFR: 8273433: Enable parallelism in vmTestbase_nsk_sysdict tests

Aleksey Shipilev shade at openjdk.java.net
Thu Sep 9 13:45:10 UTC 2021


On Wed, 8 Sep 2021 19:43:09 GMT, Mikhailo Seledtsov <mseledtsov at openjdk.org> wrote:

>> Current `vmTestbase_nsk_sysdict` suite contains about 20 tests, each running exclusively. There seem to be no reason to run them exclusively, though: they complete in reasonable time, are single-threaded, and consume the usual amount of memory.
>> 
>> We should consider enabling parallelism for them and get improved test performance. Currently it is blocked by `TEST.properties` with `exclusiveAccess.dirs` directives in them.
>> 
>> Motivational performance improvements below.
>> 
>> Before:
>> 
>> 
>> $ time CONF=linux-x86_64-server-fastdebug make run-test TEST=vmTestbase_nsk_sysdict | ts -s
>> ...
>> 00:45:14 ==============================
>> 00:45:14 Test summary
>> 00:45:14 ==============================
>> 00:45:14    TEST                                              TOTAL  PASS  FAIL ERROR   
>> 00:45:14    jtreg:test/hotspot/jtreg:vmTestbase_nsk_sysdict      20    20     0     0   
>> 00:45:14 ==============================
>> 00:45:14 TEST SUCCESS
>> 00:45:14 
>> 00:45:15 Finished building target 'run-test' in configuration 'linux-x86_64-server-fastdebug'
>> 
>> real	45m14.839s
>> user	149m49.850s
>> sys	13m25.849s
>> 
>> 
>> After:
>> 
>> 
>> $ time CONF=linux-x86_64-server-fastdebug make run-test TEST=vmTestbase_nsk_sysdict | ts -s
>> ...
>> 00:03:25 ==============================
>> 00:03:25 Test summary
>> 00:03:25 ==============================
>> 00:03:25    TEST                                              TOTAL  PASS  FAIL ERROR   
>> 00:03:25    jtreg:test/hotspot/jtreg:vmTestbase_nsk_sysdict      20    20     0     0   
>> 00:03:25 ==============================
>> 00:03:25 TEST SUCCESS
>> 00:03:25 
>> 00:03:25 Finished building target 'run-test' in configuration 'linux-x86_64-server-fastdebug'
>> 
>> real	3m24.702s
>> user	119m7.488s
>> sys	8m11.716s
>
> Thanks Alexey. I will run some tests, look into history of tests and will get back to you with my findings tonight (PST) or tomorrow.

OK, good, thanks for testing, @mseledts! I'll be on lookout if these tests start to misbehave after this relaxation.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5389


More information about the hotspot-runtime-dev mailing list