RFR: 8273522: Rename test property vm.cds.archived.java.heap to vm.cds.write.archived.java.heap
Yumin Qi
minqi at openjdk.java.net
Thu Sep 9 23:51:06 UTC 2021
On Thu, 9 Sep 2021 20:28:55 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> The vm.cds.archived.java.heap test property (see test/jtreg-ext/requires/VMProps.java) is ambiguous -- after JDK-8270489, there are now two distinct capabilities:
>
> - HeapShared::can_write() -- G1 only
> - HeapShared::can_read() -- G1, Epsilon
>
> A few CDS tests are marked with
>
>
> @requires vm.cds.archived.java.heap
>
>
> These tests actually require the VM to be able to write Java objects into the CDS archive. Therefore, for clarify, they should be changed to use
>
>
> @requires vm.cds.write.archived.java.heap
>
>
> *****
> This fix is required for JDK-8273508 - "Support archived heap objects in SerialGC".
>
> Without this fix, tests marked with `@requires vm.cds.archived.java.heap` would be executed even if SerialGC is selected, but this will dump CDS archives without archived heap objects, causing the tests to fail.
LGTM.
-------------
Marked as reviewed by minqi (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5455
More information about the hotspot-runtime-dev
mailing list