RFR: 8271569: Clean up the use of CDS constants and field offsets [v4]

[Stefan Karlsson]

On Tue, 14 Sep 2021 04:18:56 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/share/cds/cdsConstants.cpp line 26:
>> 
>>> 24: 
>>> 25: #include "precompiled.hpp"
>>> 26: #include <cstddef>
>> 
>> It is not stated in the style guide, but I think most files include the system headers after the HotSpot headers, separated by a blank line.
>
> Is this even needed now? I don't see it being used.

To be clear, the layout that I'd like to see is:

#include "precompiled.hpp"
#include "cds.hpp"
...
#include "cds/filemap.hpp"

#include <cstddef>


However, I think the more appropriate change is to include globalDefinitions.hpp instead of explicitly including cstddef.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5450