RFR: 8271569: Clean up the use of CDS constants and field offsets [v7]

Yumin Qi minqi at openjdk.java.net
Tue Sep 14 22:49:56 UTC 2021


On Tue, 14 Sep 2021 22:07:10 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> The pre-submit tests failed to build hotspot for linux on arm/ppc/s390 etc after <cstddef> removed. <cstddef> needed for defining size_t. So will add it back at last section of 'include'.
>
> The problem is here in cdsConstants.hpp
> 
> 
> #include "memory/allStatic.hpp"
> typedef struct {
>   const char* _name;
>   size_t _value;
> } CDSConst;
> 
> 
> globalDefinitions.hpp should be included here for the declaration of `size_t`.

Yes, but it still failed for non-pch since cds.h is before cdsConstants.hpp. size_t in cds.h is not defined yet. Should I add it to cds.h?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5450


More information about the hotspot-runtime-dev mailing list